[webkit-reviews] review denied: [Bug 25144] [Qt] Adding QWebHistory::addItem : [Attachment 29433] patch - 2nd try

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 22 22:56:32 PDT 2009


Holger Freyther <zecke at selfish.org> has denied Mohammed Sameer
<msameer at foolab.org>'s request for review:
Bug 25144: [Qt] Adding QWebHistory::addItem
https://bugs.webkit.org/show_bug.cgi?id=25144

Attachment 29433: patch - 2nd try
https://bugs.webkit.org/attachment.cgi?id=29433&action=review

------- Additional Comments from Holger Freyther <zecke at selfish.org>
Saying r=- right now as the history will unlikely be mutable. Is the
constructor you are using everything you need? Do you need any other
attributes?


More information about the webkit-reviews mailing list