[webkit-reviews] review requested: [Bug 25689] [Qt] Implement SearchPopupMenuQt : [Attachment 30606] Implementation for Qt using QSettings and QWebSettings with ChangeLog

[bugzilla-daemon at webkit.org]

Holger Freyther <zecke at selfish.org> has asked  for review:
Bug 25689: [Qt] Implement SearchPopupMenuQt
https://bugs.webkit.org/show_bug.cgi?id=25689

Attachment 30606: Implementation for Qt using QSettings and QWebSettings with
ChangeLog
https://bugs.webkit.org/attachment.cgi?id=30606&action=review

------- Additional Comments from Holger Freyther <zecke at selfish.org>
So far only changed to const QString as requested by George. My take on privacy
is the following:
   - It is off by default
   - The "cached" queries are never revealed to HTML/JS
   - It is using QSettings(appName, orgName) so outside of the app it is not
used. For hosts like dashboard/plasma if you open the google search in two
plasmoids this google field will have a shared history... I think that is
feature and not a security issue?