[webkit-reviews] review denied: [Bug 25503] Add instrumentation framework to WebCore : [Attachment 30205] Addresses some comments and rebases against r43514

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 22 20:22:34 PDT 2009


Oliver Hunt <oliver at apple.com> has denied James Robinson <jamesr at google.com>'s
request for review:
Bug 25503: Add instrumentation framework to WebCore
https://bugs.webkit.org/show_bug.cgi?id=25503

Attachment 30205: Addresses some comments and rebases against r43514
https://bugs.webkit.org/attachment.cgi?id=30205&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
I am not sure why these need to use client objects -- as this is primarily of
value to developers it should be entirely inside webcore with appropriate
bindings to the inspector.  Currently it sits in the inspector directory but
the inspector does not use it at all.

I feel it's value in DRT is vastly less than in the inspector so there should
be at least rudimentary information displayed in the inspector as part of this
patch.

Also you're adding branches to some very hot code paths so i'd like to be sure
that you've ensured that there isn't a performance regression in layout or
rendering.

Given these issues i'm r-'ing this for now


More information about the webkit-reviews mailing list