[webkit-reviews] review granted: [Bug 25902] Need to implement WorkerContext.close() : [Attachment 30590] Implementation of WorkerContext.close() + layout test
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri May 22 20:08:48 PDT 2009
Eric Seidel <eric at webkit.org> has granted Andrew Wilson <atwilson at google.com>'s
request for review:
Bug 25902: Need to implement WorkerContext.close()
https://bugs.webkit.org/show_bug.cgi?id=25902
Attachment 30590: Implementation of WorkerContext.close() + layout test
https://bugs.webkit.org/attachment.cgi?id=30590&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
Looks good to me. I think the test would be slightly more clear if you called
worker.postMessge('ping') *before* calling close, to show that the ping worked
before the close.
This looks fine though. Marking r+, someone else will have to land this though
because I'm about to get on a plane.
More information about the webkit-reviews
mailing list