[webkit-reviews] review denied: [Bug 23296] add Android platform-specific files to WebCore/platform : [Attachment 29999] new patch part 4 with ChangeLog

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Feng Qian <feng at chromium.org>'s
request for review:
Bug 23296: add Android platform-specific files to WebCore/platform
https://bugs.webkit.org/show_bug.cgi?id=23296

Attachment 29999: new patch part 4 with ChangeLog
https://bugs.webkit.org/attachment.cgi?id=29999&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Does the Andriod project have a legal entity to assign copyright to?

case: statements should be alingned with switch statement per the WK style
guidelines.

{ on it's own line:
 36 static int windowsKeyCodeForKeyEvent(unsigned int keyCode) {

It's sad that more of this logic can't be shared between platforms.

WK Style has no != 0
 218	 , m_shiftKey((mods & ShiftKey) != 0)

Otherwise looks fine.
If you had commit-bit I would just r+ this and you could fix them when landing.
 Since you don't yet, please post a new patch for someone else to land.