[webkit-reviews] review denied: [Bug 23296] add Android platform-specific files to WebCore/platform : [Attachment 30000] new patch part 5 with ChangeLog
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri May 22 06:32:15 PDT 2009
Eric Seidel <eric at webkit.org> has denied Feng Qian <feng at chromium.org>'s
request for review:
Bug 23296: add Android platform-specific files to WebCore/platform
https://bugs.webkit.org/show_bug.cgi?id=23296
Attachment 30000: new patch part 5 with ChangeLog
https://bugs.webkit.org/attachment.cgi?id=30000&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
I don't think you want to return a new string every time. You should use
function-local statics instead. You also don't need to use fromUTF8 since
those are just ascii strings. :) Oh, and you should put a simple
implementation of image title, since it's not that hard, and will fix viewing
stand-alone image files.
More information about the webkit-reviews
mailing list