[webkit-reviews] review denied: [Bug 25494] add PositionConstructors.h in preparation for adding more position constructor functions : [Attachment 29927] Add more position constructors
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri May 22 01:38:36 PDT 2009
Maciej Stachowiak <mjs at apple.com> has denied Eric Seidel <eric at webkit.org>'s
request for review:
Bug 25494: add PositionConstructors.h in preparation for adding more position
constructor functions
https://bugs.webkit.org/show_bug.cgi?id=25494
Attachment 29927: Add more position constructors
https://bugs.webkit.org/attachment.cgi?id=29927&action=review
------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
r- because this depends on the previous r-'d patches. Also: I would request
that you not add unused functions. Please add them with at least one real use
that has test coverage, so we don't have untested dead code in the tree.
More information about the webkit-reviews
mailing list