[webkit-reviews] review denied: [Bug 25494] add PositionConstructors.h in preparation for adding more position constructor functions : [Attachment 29926] Rename positionBeforeNode to positionInParentBeforeNode

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 22 01:37:03 PDT 2009


Maciej Stachowiak <mjs at apple.com> has denied Eric Seidel <eric at webkit.org>'s
request for review:
Bug 25494: add PositionConstructors.h in preparation for adding more position
constructor functions
https://bugs.webkit.org/show_bug.cgi?id=25494

Attachment 29926: Rename positionBeforeNode to positionInParentBeforeNode
https://bugs.webkit.org/attachment.cgi?id=29926&action=review

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
I repeat my earlier comments about removing "Node" from the names of these
functions. Otherwise looks ok, but this depends on the previous patch which I
r-'d, so r- for this too.


More information about the webkit-reviews mailing list