[webkit-reviews] review denied: [Bug 24114] ESMP(ECMAScript Mobile Profile) not supported : [Attachment 30502] Updated patch for ESMP to support casecensitive attribute of element

[bugzilla-daemon at webkit.org]

Maciej Stachowiak <mjs at apple.com> has denied yichao.yin
<yichao.yin at torchmobile.com.cn>'s request for review:
Bug 24114: ESMP(ECMAScript Mobile Profile) not supported
https://bugs.webkit.org/show_bug.cgi?id=24114

Attachment 30502: Updated patch for ESMP to support casecensitive attribute of
element
https://bugs.webkit.org/attachment.cgi?id=30502&action=review

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
It's unfortunate to do this by adding completely duplicate versions of
removeAttribute/getAttribute/setAttribute. Perhaps at least some of these could
just have the extra parameter and use of it as an #ifdef but share most of the
body.

Also, I don't understand why custom bindings are needed for getAttribute and
removeAttribute. Why was that done? The ChangeLog should explain.

Please address these comments and repost.