[webkit-reviews] review denied: [Bug 24114] ESMP(ECMAScript Mobile Profile) not supported : [Attachment 30501] Updated patch for ESMP URIError handling

[bugzilla-daemon at webkit.org]

Maciej Stachowiak <mjs at apple.com> has denied yichao.yin
<yichao.yin at torchmobile.com.cn>'s request for review:
Bug 24114: ESMP(ECMAScript Mobile Profile) not supported
https://bugs.webkit.org/show_bug.cgi?id=24114

Attachment 30501: Updated patch for ESMP URIError handling
https://bugs.webkit.org/attachment.cgi?id=30501&action=review

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
Typo in the ChangeLog:

+	 Through URIError for invalid URIs for location, for compliance with
ESMP(OMA-WAP-ESMP-V1_0),

This should say "Throw", not "Through".

throwError(exec, URIError, (String("Invalid URI ") + dstUrl).utf8().data());

The .utf8().data() is not appropriate, this makes a temporary char*. Instead,
you can just pass a String and rely on WebCore::String's implicit conversion to
UString. This error appears in the code twice.

Please address the above comments and repost.