[webkit-reviews] review denied: [Bug 24114] ESMP(ECMAScript Mobile Profile) not supported : [Attachment 30500] Updated patch for new ESMP error support

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 22 00:19:05 PDT 2009


Maciej Stachowiak <mjs at apple.com> has denied yichao.yin
<yichao.yin at torchmobile.com.cn>'s request for review:
Bug 24114: ESMP(ECMAScript Mobile Profile) not supported
https://bugs.webkit.org/show_bug.cgi?id=24114

Attachment 30500: Updated patch for new ESMP error support
https://bugs.webkit.org/attachment.cgi?id=30500&action=review

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
Minor style comment:

+#if ENABLE(ESMP)
+	 URIError	= 6,
+	 MemoryError	= 7
+#else
	 URIError	= 6
+#endif

It's ok to leave a trailing comma after the last enum element, so you don't
need to duplicate URIError.I'm not a fan of the other code duplicate in the
patch, but I don't see an easy way to avoid it.

r- to address the minor style comment. Please repost a patch with that
addressed.


More information about the webkit-reviews mailing list