[webkit-reviews] review denied: [Bug 25427] Fix a bug in MediaDocument.cpp that gets triggered when entering a media file in address bar : [Attachment 29876] change log + patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 14 22:21:05 PDT 2009


Eric Seidel <eric at webkit.org> has denied Hin-Chung Lam <hclam at google.com>'s
request for review:
Bug 25427: Fix a bug in MediaDocument.cpp that gets triggered when entering a
media file in address bar
https://bugs.webkit.org/show_bug.cgi?id=25427

Attachment 29876: change log + patch
https://bugs.webkit.org/attachment.cgi?id=29876&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Style violations { don't go on their own line for if's.

also, why is this correct?  does this match other Document.cpp finish()
methods?  Seems it needs a comment to that effect.


More information about the webkit-reviews mailing list