[webkit-reviews] review denied: [Bug 25068] Complex text support for Chromium Linux : [Attachment 29298] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 14 22:14:55 PDT 2009

Eric Seidel <eric at webkit.org> has denied Adam Langley <agl at chromium.org>'s
request for review:
Bug 25068: Complex text support for Chromium Linux

Attachment 29298: patch

------- Additional Comments from Eric Seidel <eric at webkit.org>
Bah,  I hit submit early.

All the places you use "harfbuzz" probably should hav ea differnet name.  We
don't care that we're using "harfbuzz" more that we're iterating over the text
runs or?

What is iter doing here?
 393	     ssize_t iter = 0;
 394	     while (iter < run.length()) {

Seems that too needs a better name.

r- for all the nits above.

More information about the webkit-reviews mailing list