[webkit-reviews] review denied: [Bug 25068] Complex text support for Chromium Linux : [Attachment 29298] patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Adam Langley <agl at chromium.org>'s
request for review:
Bug 25068: Complex text support for Chromium Linux
https://bugs.webkit.org/show_bug.cgi?id=25068

Attachment 29298: patch
https://bugs.webkit.org/attachment.cgi?id=29298&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Bah,  I hit submit early.

All the places you use "harfbuzz" probably should hav ea differnet name.  We
don't care that we're using "harfbuzz" more that we're iterating over the text
runs or?

What is iter doing here?
 393	     ssize_t iter = 0;
 394	     while (iter < run.length()) {

Seems that too needs a better name.

r- for all the nits above.