[webkit-reviews] review requested: [Bug 25689] [Qt] Implement SearchPopupMenuQt : [Attachment 30334] Add SearchPopupMenuDelegate to bridge to the Kit

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 14 07:10:02 PDT 2009


Holger Freyther <zecke at selfish.org> has asked  for review:
Bug 25689: [Qt] Implement SearchPopupMenuQt
https://bugs.webkit.org/show_bug.cgi?id=25689

Attachment 30334: Add SearchPopupMenuDelegate to bridge to the Kit
https://bugs.webkit.org/attachment.cgi?id=30334&action=review

------- Additional Comments from Holger Freyther <zecke at selfish.org>
Add Document* to the signature (like we did for Cookies), and pick *Delegate as
the name as we have a PopupMenuClient and a SearchPopupMenuClient would be
different. The Delegate approach was used for the Clipboard implementation on
Gtk+ as well.

Also start using the new #if USE() instead of having PLATFORM(GTK) &&
PLATFORM(QT) and share the generic part.


More information about the webkit-reviews mailing list