[webkit-reviews] review cancelled: [Bug 25689] [Qt] Implement SearchPopupMenuQt : [Attachment 30185] Implementation using QSettings

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 14 07:10:02 PDT 2009

Holger Freyther <zecke at selfish.org> has cancelled Holger Freyther
<zecke at selfish.org>'s request for review:
Bug 25689: [Qt] Implement SearchPopupMenuQt

Attachment 30185: Implementation using QSettings

------- Additional Comments from Holger Freyther <zecke at selfish.org>
Add Document* to the signature (like we did for Cookies), and pick *Delegate as
the name as we have a PopupMenuClient and a SearchPopupMenuClient would be
different. The Delegate approach was used for the Clipboard implementation on
Gtk+ as well.

Also start using the new #if USE() instead of having PLATFORM(GTK) &&
PLATFORM(QT) and share the generic part.

More information about the webkit-reviews mailing list