[webkit-reviews] review denied: [Bug 25742] Fix RenderThemeChromiumWin::paintTextFieldInternal() not to hide background image. : [Attachment 30258] Proposed fix for 25742

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 12 19:14:50 PDT 2009


Eric Seidel <eric at webkit.org> has denied Takeshi Yoshino
<tyoshino at google.com>'s request for review:
Bug 25742: Fix RenderThemeChromiumWin::paintTextFieldInternal() not to hide
background image.
https://bugs.webkit.org/show_bug.cgi?id=25742

Attachment 30258: Proposed fix for 25742
https://bugs.webkit.org/attachment.cgi?id=30258&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Brett Wilson is not a webkit reviewer.	You also do not need to mark the
requestee field for WebKit reviews.

I would have written this line:

Color backgroundColor = o->style()->backgroundColor().isValid() ?
o->style()->backgroundColor() : Color::white;

Does this match other platforms' behaviors here?

This needs test cases.


More information about the webkit-reviews mailing list