[webkit-reviews] review granted: [Bug 25738] Skia: CSS border style not cleared for SVG object : [Attachment 30256] Patch: override with SolidStroke if no dash set

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 12 18:26:24 PDT 2009


Eric Seidel <eric at webkit.org> has granted Roland Steiner
<rolandsteiner at google.com>'s request for review:
Bug 25738: Skia: CSS border style not cleared for SVG object
https://bugs.webkit.org/show_bug.cgi?id=25738

Attachment 30256: Patch: override with SolidStroke if no dash set
https://bugs.webkit.org/attachment.cgi?id=30256&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
I'm a good choice to review this.  But you don't actually need to specify a
reviewer for WebKit reviews.  In fact, they'll often happen quicker if you
don't.

This change needs a test case as part of the patch.  Otherwise, this looks
fine.  I'll add the test you provided when I land this (even though the test
already passes for WebKit Mac).


More information about the webkit-reviews mailing list