[webkit-reviews] review requested: [Bug 25087] Test for ENABLE_FOO macros consistently in IDL files : [Attachment 30202] Patch v2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 11 13:59:26 PDT 2009


David Kilzer (ddkilzer) <ddkilzer at webkit.org> has asked  for review:
Bug 25087: Test for ENABLE_FOO macros consistently in IDL files
https://bugs.webkit.org/show_bug.cgi?id=25087

Attachment 30202: Patch v2
https://bugs.webkit.org/attachment.cgi?id=30202&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
Change tests for ENABLE macros to check for both existance and value:

- Negative:  #if !defined(ENABLE_FOO) || !ENABLE_FOO
- Positive:  #if defined(ENABLE_FOO) && ENABLE_FOO


More information about the webkit-reviews mailing list