[webkit-reviews] review denied: [Bug 25701] REGRESSION(r38788 & r42020): styled searchfields look wrong on Windows, affects Facebook : [Attachment 30199] proposed patch without testcase

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 11 13:00:02 PDT 2009


Dave Hyatt <hyatt at apple.com> has denied 's request for review:
Bug 25701: REGRESSION(r38788 & r42020): styled searchfields look wrong on
Windows, affects Facebook
https://bugs.webkit.org/show_bug.cgi?id=25701

Attachment 30199: proposed patch without testcase
https://bugs.webkit.org/attachment.cgi?id=30199&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
I don't think you intended to prevent the specification of padding on text
fields.  I'm pretty sure browsers allow the padding of text fields to be
customized.

It's not clear to me why we can't support customizable padding on search
fields, so I don't really understand why we'd prevent that?

I believe you can just remove the rule for input[type="search"] to get
-webkit-appearance: searchfield, right?  I assume that's specified in the base
CSS file already.


More information about the webkit-reviews mailing list