[webkit-reviews] review denied: [Bug 24546] [x86_64] JITArithmetic does not build : [Attachment 28527] Proposed fix for x86_64

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 11 09:53:33 PDT 2009


Geoffrey Garen <ggaren at apple.com> has denied Gabor Loki
<loki at inf.u-szeged.hu>'s request for review:
Bug 24546: [x86_64] JITArithmetic does not build
https://bugs.webkit.org/show_bug.cgi?id=24546

Attachment 28527: Proposed fix for x86_64
https://bugs.webkit.org/attachment.cgi?id=28527&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
There's no harm in this patch, but it won't work. On 64bit, you can't compare a
pointer to a 32bit immediate. This code should be #ifdef'd out in a 64bit
build.


More information about the webkit-reviews mailing list