[webkit-reviews] review denied: [Bug 25513] V8 CSSStyleDeclaration bindings are slow : [Attachment 29949] Fix

[bugzilla-daemon at webkit.org]

Dimitri Glazkov (Google) <dglazkov at chromium.org> has denied Dave Moore
<davemoore at google.com>'s request for review:
Bug 25513: V8 CSSStyleDeclaration bindings are slow
https://bugs.webkit.org/show_bug.cgi?id=25513

Attachment 29949: Fix
https://bugs.webkit.org/attachment.cgi?id=29949&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
Just a few nits/comments:

> +class CSSPropertyInfo {
> +  public:

align public to class.

> +    static HashMap<String, CSSPropertyInfo*> map;

Use DEFINE_STATIC_LOCAL macro.

> +	   if (!length)
> +	       return NULL;

return 0.

> +	   else if (WTF::isASCIIUpper(propertyName[0]))
> +	       return NULL;

return 0.

> -    INC_STATS("DOM.CSSStyleDeclaration.NamedPropertyGetter");
> +    //INC_STATS("DOM.CSSStyleDeclaration.NamedPropertyGetter");

Did you mean leave this in?