[webkit-reviews] review granted: [Bug 25464] Improve font fallback for 'common' characters in Chromium Win port : [Attachment 29946] patch

[bugzilla-daemon at webkit.org]

Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Jungshik Shin
<jshin at chromium.org>'s request for review:
Bug 25464: Improve font fallback for 'common' characters in Chromium Win port
https://bugs.webkit.org/show_bug.cgi?id=25464

Attachment 29946: patch 
https://bugs.webkit.org/attachment.cgi?id=29946&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
Looks good except for style comments:

> +UScriptCode getScriptBasedOnUnicodeBlock(int ucs4)

Add static modifier.

> +UScriptCode getScript(int ucs4)

Ditto.

> +    if (script <= USCRIPT_INHERITED || U_FAILURE(err))
> +	 script = getScriptBasedOnUnicodeBlock(ucs4);

4 spaces.