[webkit-reviews] review requested: [Bug 25512] Texts in some unfinished tags aren't visible in view-source mode : [Attachment 29948] Handle texts in unfinished special tags.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat May 2 14:01:41 PDT 2009
Shinichiro Hamaji <hamaji at google.com> has asked for review:
Bug 25512: Texts in some unfinished tags aren't visible in view-source mode
https://bugs.webkit.org/show_bug.cgi?id=25512
Attachment 29948: Handle texts in unfinished special tags.
https://bugs.webkit.org/attachment.cgi?id=29948&action=review
------- Additional Comments from Shinichiro Hamaji <hamaji at google.com>
Thanks for the review! I forgot to change the flag for review, sorry.
Regarding the name "special", I agree that this name isn't good, but it's a bit
difficult to find a good name... How about "non HTML text" since these tags
have non HTML text node as their child node? If it sounds good to you, I'll
modify the patch in the beginning of the next week. I think we need to change
the function name "parseSpecial" to "parseNonHtmlText" as well.
Thanks!
More information about the webkit-reviews
mailing list