[webkit-reviews] review granted: [Bug 25466] WebKitGtk+ 1.1.6 prints weird error messages in Liferea : [Attachment 29956] Calculate the size of the string correctly
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat May 2 12:31:47 PDT 2009
Holger Freyther <zecke at selfish.org> has granted Gustavo Noronha (kov)
<gns at gnome.org>'s request for review:
Bug 25466: WebKitGtk+ 1.1.6 prints weird error messages in Liferea
https://bugs.webkit.org/show_bug.cgi?id=25466
Attachment 29956: Calculate the size of the string correctly
https://bugs.webkit.org/attachment.cgi?id=29956&action=review
------- Additional Comments from Holger Freyther <zecke at selfish.org>
> - RefPtr<SharedBuffer> sharedBuffer = SharedBuffer::create(content,
g_utf8_strlen(content, -1));
> + RefPtr<SharedBuffer> sharedBuffer = SharedBuffer::create(content,
strlen(content));
Yes it makes sense, maybe you also want to add a unit test and compare the html
with the one we set?
More information about the webkit-reviews
mailing list