[webkit-reviews] review granted: [Bug 25487] windows-949 returned by document.{charset, characterset} is not recognized by Korean advertising servers : [Attachment 29959] updated patch addressing ap's concerns

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat May 2 11:12:38 PDT 2009


Alexey Proskuryakov <ap at webkit.org> has granted Jungshik Shin
<jshin at chromium.org>'s request for review:
Bug 25487: windows-949 returned by document.{charset,characterset}  is not
recognized by Korean advertising servers
https://bugs.webkit.org/show_bug.cgi?id=25487

Attachment 29959: updated patch addressing ap's concerns
https://bugs.webkit.org/attachment.cgi?id=29959&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
-	 return d->encoding().name();
+	 return d->encoding().displayName();

Please make sure that WebKit builds before landing - this should be domName().

r=me


More information about the webkit-reviews mailing list