[webkit-reviews] review requested: [Bug 25487] windows-949 returned by document.{charset, characterset} is not recognized by Korean advertising servers : [Attachment 29959] updated patch addressing ap's concerns

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat May 2 09:46:11 PDT 2009


Jungshik Shin <jshin at chromium.org> has asked Alexey Proskuryakov
<ap at webkit.org> for review:
Bug 25487: windows-949 returned by document.{charset,characterset}  is not
recognized by Korean advertising servers
https://bugs.webkit.org/show_bug.cgi?id=25487

Attachment 29959: updated patch addressing ap's concerns
https://bugs.webkit.org/attachment.cgi?id=29959&action=review

------- Additional Comments from Jungshik Shin <jshin at chromium.org>
Thank you for the review. Can you take another look? 

I addressed all the comments except for the last one. I took #1 because
x-windows-949 is very rarely - if ever - used by a web server. It's basically
my 'invention' (used internally in Gecko not meant to be exposed although it's
when 'x-windows-949' or 'ks_c_5601-1987' - a wrong name to use to begin with -
is specified by a web server).


More information about the webkit-reviews mailing list