[webkit-reviews] review denied: [Bug 23310] Setting an absolute path (/abs) on an <iframe> with no src doesn't resolve the URL properly : [Attachment 27910] Patch for the bug
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Mar 23 18:05:45 PDT 2009
David Kilzer (ddkilzer) <ddkilzer at webkit.org> has denied David Kilzer
(ddkilzer) <ddkilzer at webkit.org>'s request for review:
Bug 23310: Setting an absolute path (/abs) on an <iframe> with no src doesn't
resolve the URL properly
https://bugs.webkit.org/show_bug.cgi?id=23310
Attachment 27910: Patch for the bug
https://bugs.webkit.org/attachment.cgi?id=27910&action=review
------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
This patch:
- Adds needless whitespace.
- Has no ChangeLog entries.
- Has no layout test.
- Uses tabs instead of spaces for indenting.
- Includes commented-out code.
- Is needless complex for this fix.
I'm sorry I can't go into more detail here, but see
<http://webkit.org/coding/contributing.html> for some guidelines.
I really appreciate your effort to fix the bug, so please don't let this deter
you from submitting patches in the future. Thanks!
More information about the webkit-reviews
mailing list