[webkit-reviews] review granted: [Bug 24760] Clean up Position.h : [Attachment 28876] Second stab at making Position::container private

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 23 17:32:20 PDT 2009

Darin Adler <darin at apple.com> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 24760: Clean up Position.h

Attachment 28876: Second stab at making Position::container private

------- Additional Comments from Darin Adler <darin at apple.com>
>  inline Node* RangeBoundaryPoint::container() const
>  {
> -    return m_position.container.get();
> +    // FIXME: node() is not necessarily the container node!
> +    return m_position.node();
>  }

This FIXME is wrong. The way RangeBoundaryPoint uses Position, everything is
perfectly find, and this is indeed the container. It's the uses of Position in
editing code that have the problem you mention in the definition of node. The
Range class works perfectly here and there's no problem, so I think it's really
misleading to have a FIXME here.

r=me though

More information about the webkit-reviews mailing list