[webkit-reviews] review requested: [Bug 23900] Crash if any frame in a frameset is named _top : [Attachment 28786] The right way to fix this

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 20 10:11:40 PDT 2009


Sverrir Á. Berg <sverrir at chromium.org> has asked  for review:
Bug 23900: Crash if any frame in a frameset is named _top
https://bugs.webkit.org/show_bug.cgi?id=23900

Attachment 28786: The right way to fix this
https://bugs.webkit.org/attachment.cgi?id=28786&action=review

------- Additional Comments from Sverrir Á. Berg <sverrir at chromium.org>
This is the right way to fix this.  Now frames can basically have any name they
want and even same names as other frames.  This brings WebKit in line with how
other browsers work.
Note that this breaks approx 50 tests that rely on the current name mangling
(<!--framePath //<!--frame0-->-->) of frame names.  If this patch gets a
positive review I will upload another patch that fixes these tests.


More information about the webkit-reviews mailing list