[webkit-reviews] review requested: [Bug 24586] maxDeepOffset is confusing and should be removed : [Attachment 28788] Squashed patch with renames

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 20 10:18:26 PDT 2009


Eric Seidel <eric at webkit.org> has asked  for review:
Bug 24586: maxDeepOffset is confusing and should be removed
https://bugs.webkit.org/show_bug.cgi?id=24586

Attachment 28788: Squashed patch with renames
https://bugs.webkit.org/attachment.cgi?id=28788&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
 WebCore/ChangeLog			     |	 98 +++++++++++++++++++++++++++
 WebCore/dom/Position.cpp		     |	 63 ++++++++++++------
 WebCore/dom/Position.h 		     |	 15 ++++-
 WebCore/dom/PositionIterator.cpp	     |	 18 +++--
 WebCore/editing/CompositeEditCommand.cpp    |	  4 +-
 WebCore/editing/DeleteSelectionCommand.cpp  |	 17 ++---
 WebCore/editing/Editor.cpp		     |	  3 +-
 WebCore/editing/InsertLineBreakCommand.cpp  |	  3 +-
 WebCore/editing/InsertListCommand.cpp	     |	  4 +-
 WebCore/editing/ReplaceSelectionCommand.cpp |	  5 +-
 WebCore/editing/TypingCommand.cpp	     |	  2 +-
 WebCore/editing/VisiblePosition.cpp	     |	 12 ++--
 WebCore/editing/VisibleSelection.cpp	     |	  6 +-
 WebCore/editing/htmlediting.cpp	     |	 44 +++++++------
 WebCore/editing/htmlediting.h		     |	  2 +-
 WebCore/editing/visible_units.cpp	     |	 27 ++++----
 WebCore/page/AccessibilityObject.cpp	     |	  4 +-
 WebCore/page/AccessibilityRenderObject.cpp  |	 13 ++--
 WebCore/rendering/RenderBox.cpp	     |	  9 +--
 19 files changed, 246 insertions(+), 103 deletions(-)


More information about the webkit-reviews mailing list