[webkit-reviews] review requested: [Bug 24467] [chromium] default border for IMG is drawn outset instead of inset : [Attachment 28595] patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 13 13:50:00 PDT 2009


Peter Kasting <pkasting at google.com> has asked  for review:
Bug 24467: [chromium] default border for IMG is drawn outset instead of inset
https://bugs.webkit.org/show_bug.cgi?id=24467

Attachment 28595: patch v1
https://bugs.webkit.org/attachment.cgi?id=28595&action=review

------- Additional Comments from Peter Kasting <pkasting at google.com>
This makes drawRect() ignore the stroke width (like CG does), and adds a
warning comment about that to the appropriate header.

It also eliminates some hacky code in Skia's stroke preparation, which seems
inappropriate because (a) it didn't match CG's behavior and (b) it would do
something obviously wrong when other transforms (e.g. global zoom) were
applied.


More information about the webkit-reviews mailing list