[webkit-reviews] review granted: [Bug 24524] Introduce ScriptFunctionCall and ScriptObject abstractions : [Attachment 28584] Introduce ScriptObject and ScriptFunctionCall abstractions, v2.1.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 13 13:49:38 PDT 2009


Timothy Hatcher <timothy at hatcher.name> has granted Dimitri Glazkov (Google)
<dglazkov at chromium.org>'s request for review:
Bug 24524: Introduce ScriptFunctionCall and ScriptObject abstractions
https://bugs.webkit.org/show_bug.cgi?id=24524

Attachment 28584: Introduce ScriptObject and ScriptFunctionCall abstractions,
v2.1.
https://bugs.webkit.org/attachment.cgi?id=28584&action=review

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
Looks good, only two comments.

Don't indent the functions in the .cpp files inside the namespace block.

And getQuarantinedScriptObject seems a little large to be an inline function,
so that should likely have a .cpp file to contain the implementation.


More information about the webkit-reviews mailing list