[webkit-reviews] review requested: [Bug 24453] REGRESSION: After calling framed setTimeout on https page, DOM changes are not flushed : [Attachment 28500] Proposed patch

[bugzilla-daemon at webkit.org]

Dmitry Titov <dimich at chromium.org> has asked  for review:
Bug 24453: REGRESSION: After calling framed setTimeout on https page, DOM
changes are not flushed
https://bugs.webkit.org/show_bug.cgi?id=24453

Attachment 28500: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=28500&action=review

------- Additional Comments from Dmitry Titov <dimich at chromium.org>
The key here is that setTimeout is called on a window object of <iframe>. This
creates a timer that has that window as an 'executing context'. The callback's
JS function is defined in the parent document's scope and when it executes, it
updates the parent document. However, the code calls updateRendering() on a
document that is associated with the window of <iframe> - and with certain
timing, it causes missing update of the parent document until some other event
(like mousemove) causes update.

The proposed fix is to use Document::updateDocumentsRendering() instead since
it will update all the affected documents right away.

So far, I was unable to create a local test that would reproduce the bug.