[webkit-reviews] review requested: [Bug 14749] percentage top value on position:relative child not calculated correctly if parent has percentage height : [Attachment 28501] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 11 16:13:47 PDT 2009


Beth Dakin <bdakin at apple.com> has asked  for review:
Bug 14749: percentage top value on position:relative child not calculated
correctly if parent has percentage height
https://bugs.webkit.org/show_bug.cgi?id=14749

Attachment 28501: Patch
https://bugs.webkit.org/attachment.cgi?id=28501&action=review

------- Additional Comments from Beth Dakin <bdakin at apple.com>
Hyatt and I talked about this change on IRC. He felt a bit nervous about it
because he had a vague feeling that there was some reason we originally
included the if-statements that I remove with this patch, but he couldn't quite
remember what it what. Here is what I can tell potential reviewers about the
potential validity of this patch:

-The new behavior matches Firefox and IE with the given test cases. 
-All LayoutTests pass.
-I searched through the history of these lines of code with the aid of trac's
handy annotate feature. The if-statements were added in revision 4! So I take
it kocienda was just merging them over from khtml.


More information about the webkit-reviews mailing list