[webkit-reviews] review granted: [Bug 23028] Enable web/dynamic font support for Chromium on Windows : [Attachment 28227] patch part 1 updated without the failure-prone part of vcproj patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 3 09:59:57 PST 2009


Jungshik Shin <jshin at chromium.org> has granted 's request for review:
Bug 23028: Enable web/dynamic font support for Chromium on Windows
https://bugs.webkit.org/show_bug.cgi?id=23028

Attachment 28227: patch part 1 updated	without the failure-prone part of
vcproj patch.
https://bugs.webkit.org/attachment.cgi?id=28227&action=review

------- Additional Comments from Jungshik Shin <jshin at chromium.org>
Carrying over Eric's r+ because nothing of substance has changed (only vcproj
file was changed). I gave this updated patch to Dimitri off-line, but I'm
uploading it here as well in case somebody tries to land it and encounters a
patch failure. 

This does not have a part of WebCore.vcproj patch that tends to fail to be
applied AND is hard/tedious to apply by hand. I'm gonna upload a script for
that part.


More information about the webkit-reviews mailing list