[webkit-reviews] review granted: [Bug 24321] Add V8 bindings headers : [Attachment 28223] Add V8 bindings headers

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <darin at chromium.org> has granted Dimitri Glazkov
(Google) <dglazkov at chromium.org>'s request for review:
Bug 24321: Add V8 bindings headers
https://bugs.webkit.org/show_bug.cgi?id=24321

Attachment 28223: Add V8 bindings headers
https://bugs.webkit.org/attachment.cgi?id=28223&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<darin at chromium.org>
>+++ b/WebCore/ChangeLog
...
>+	  * bindings/v8/V8Binding.h: Added.
>+	  (WebCore::toInt32):
>+	  (WebCore::toFloat):
>+	  (WebCore::toWebCoreString):
>+	  (WebCore::toWebCoreStringWithNullCheck):
>+	  (WebCore::isUndefinedOrNull):
>+	  (WebCore::v8Boolean):
>+	  * bindings/v8/V8Proxy.h: Added.
>+	  (WebCore::notHandledByInterceptor):
>+	  (WebCore::deletionNotHandledByInterceptor):
>+	  (WebCore::throwError):
>+	  (WebCore::toV8):
>+	  * bindings/v8/custom/V8CustomBinding.h: Added.
>+	  * bindings/v8/custom/V8CustomEventListener.h: Added.

nit: remove the functions listed by prepare-ChangeLog for newly
added files.


>+++ b/WebCore/bindings/v8/V8Binding.h
...
>+	  // FIXME: Rename valueToStringWithNullCheck once migration is
complete
>+    inline String toWebCoreStringWithNullCheck(v8::Handle<v8::Value> value)

nit: indentation


OK, LGTM