[webkit-reviews] review requested: [Bug 24227] Implement checkForSolidColor in ImageQt.cpp : [Attachment 28172] New version that removes wrong assert
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Mar 2 07:18:11 PST 2009
Adam Treat <treat at kde.org> has asked for review:
Bug 24227: Implement checkForSolidColor in ImageQt.cpp
https://bugs.webkit.org/show_bug.cgi?id=24227
Attachment 28172: New version that removes wrong assert
https://bugs.webkit.org/attachment.cgi?id=28172&action=review
------- Additional Comments from Adam Treat <treat at kde.org>
It seems the assert is bogus since it is set immediately if 'frameCount()' is
called which it is inside of 'checkForSolidColor' so I removed it. Also, I
made sure the Cairo version sets the m_checkedForSolidColor flag as it was
overlooked.
More information about the webkit-reviews
mailing list