[webkit-reviews] review granted: [Bug 24227] Implement checkForSolidColor in ImageQt.cpp : [Attachment 28172] New version that removes wrong assert

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 2 07:30:39 PST 2009


Adam Roben (aroben) <aroben at apple.com> has granted Adam Treat <treat at kde.org>'s
request for review:
Bug 24227: Implement checkForSolidColor in ImageQt.cpp
https://bugs.webkit.org/show_bug.cgi?id=24227

Attachment 28172: New version that removes wrong assert
https://bugs.webkit.org/attachment.cgi?id=28172&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
It's a shame to make mayFillWithSolidColor non-const. Can we make
m_checkedForSolidColor mutable and make checkForSolidColor const, too?

r=me with the change you described to mayFillWithSolidColor on IRC.


More information about the webkit-reviews mailing list