[webkit-reviews] review granted: [Bug 26659] Support hidding an control bar element from the Media element controller (display:none does not work for media control elements) : [Attachment 31882] patch v4.

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Pierre d'Herbemont
<pdherbemont at apple.com>'s request for review:
Bug 26659: Support hidding an control bar element from the Media element
controller (display:none does not work for media control elements)
https://bugs.webkit.org/show_bug.cgi?id=26659

Attachment 31882: patch v4.
https://bugs.webkit.org/attachment.cgi?id=31882&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
> +    if (renderer() && !rendererIsNeeded(style))
> +	   detach();
> +    else if (!renderer() && rendererIsNeeded(style)) {

It's probably worth changing this to call rendererIsNeeded() just once.

r=me