[webkit-reviews] review denied: [Bug 26733] Add V8 methods to notify clients about context creation/destruction : [Attachment 31877] adds 2 methods to FrameLoaderClient.h

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Matt Perry
<mpComplete at gmail.com>'s request for review:
Bug 26733: Add V8 methods to notify clients about context creation/destruction
https://bugs.webkit.org/show_bug.cgi?id=26733

Attachment 31877: adds 2 methods to FrameLoaderClient.h
https://bugs.webkit.org/attachment.cgi?id=31877&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
> Index: WebCore/ChangeLog
...
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	https://bugs.webkit.org/show_bug.cgi?id=26733
> +
> +	Add V8-only methods to FrameLoaderClient that V8 can use to send
> +	out notifications when it creates/destroys a script context.

Replace tabs with spaces


> Index: WebCore/loader/FrameLoaderClient.h
...
> +#if USE(V8)
> +	   virtual void didCreateScriptContext() const { }
> +	   virtual void didDestroyScriptContext() const { }

I think these should be pure virtual like the other FrameLoaderClient methods.

Otherwise, LG