[webkit-reviews] review denied: [Bug 26721] Pointer to incomplete class type is not allowed compilation error with RVCT : [Attachment 31856] Include Event.h in Node.h instead of forward declaring the Event class

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 25 12:03:08 PDT 2009


Darin Adler <darin at apple.com> has denied Laszlo Gombos
<laszlo.1.gombos at nokia.com>'s request for review:
Bug 26721: Pointer to incomplete class type is not allowed compilation error
with RVCT
https://bugs.webkit.org/show_bug.cgi?id=26721

Attachment 31856: Include Event.h in Node.h instead of forward declaring the
Event class
https://bugs.webkit.org/attachment.cgi?id=31856&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
We really don't want to include Event.h in every single file that includes
Node.h. Lets remove the default value for underlyingEvent, and fix the callers
to pass zero explicitly instead.


More information about the webkit-reviews mailing list