[webkit-reviews] review requested: [Bug 26698] Combined LocalStorageArea and SessionStorageArea into StorageArea : [Attachment 31869] patch v3

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 25 12:09:32 PDT 2009


Jeremy Orlow <jorlow at chromium.org> has asked  for review:
Bug 26698: Combined LocalStorageArea and SessionStorageArea into StorageArea
https://bugs.webkit.org/show_bug.cgi?id=26698

Attachment 31869: patch v3
https://bugs.webkit.org/attachment.cgi?id=31869&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
Rebuilt on HEAD and ran all layout tests again to make sure I don't break the
build again.

Only change is in StorageArea's constructor for SessionStorage.  Instead of
passing in a StorageArea pointer (that could be NULL dereferenced), I pass in a
storageMap PassRefPtr (or 0 when it's not a clone).


More information about the webkit-reviews mailing list