[webkit-reviews] review granted: [Bug 26366] [V8] Teach V8 bindings about isolated worlds : [Attachment 31640] updated patch

[bugzilla-daemon at webkit.org]

Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Adam Barth
<abarth at webkit.org>'s request for review:
Bug 26366: [V8] Teach V8 bindings about isolated worlds
https://bugs.webkit.org/show_bug.cgi?id=26366

Attachment 31640: updated patch
https://bugs.webkit.org/attachment.cgi?id=31640&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
Just a few styling nits:

> +static char kIsolatedWorldKey[] = "IsolatedWorld";

You don't have to have prefixes (k* or g_*) for statics.

> +static int g_isolatedWorldCount = 0;

> +    // Using the default security token means that the canAccess is always
> +    // called, which is slow.
> +    // TODO(aa): Use tokens where possible. This will mean keeping track of
all
> +    // created contexts so that they can all be updated when the document
domain
> +    // changes.

FIXME?

> +    // TODO(abarth): Move this statement above proxy->evaluate?  It seems
like
> +    //		we should set up the token before running the script.

FIXME?

> +V8IsolatedWorld* V8IsolatedWorld::getEntered()
> +	   return NULL;

return 0;

> +	   return NULL;

ditto.

> +	   return NULL;

ditto.