[webkit-reviews] review requested: [Bug 26609] Support CSS3 attr() function : [Attachment 31653] A first attempt to implement the CSS3 attr() function

[bugzilla-daemon at webkit.org]

Kai Brüning <kai at granus.net> has asked	for review:
Bug 26609: Support CSS3 attr() function
https://bugs.webkit.org/show_bug.cgi?id=26609

Attachment 31653: A first attempt to implement the CSS3 attr() function
https://bugs.webkit.org/attachment.cgi?id=31653&action=review

------- Additional Comments from Kai Brüning <kai at granus.net>
This patch is meant as a first attempt of an implementation. There are sure
many things to change before landing it.

The up to three parameters of CSS3-attr() are fully supported, but attr() can
not yet be used with all properties to which it would apply.

The patch introduces the concept of a "derived" value to CSSPrimitiveValue and
CSSStyleSelector. The derived value is a new CSSPrimitiveValue, which is
created only if the original value is of the newly added sub class
CSSAttrValue. The derived value is then of the type required by the attr()
function, for instance CSSImageValue.

Note that the patch includes namespace support for the attribute name (first
parameter of attr()). For this I had to change CSSGrammar.y. Probably this
won’t be the final change, because so far it does not support and empty prefix
(that is, an attribute name of the form "|name").

Please advice how to proceed to get this landed eventually.