[webkit-reviews] review denied: [Bug 26328] Changing href attribute of svg images does not work when changing display attribute as well : [Attachment 31598] Different approach

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Rob Buis <rwlbuis at gmail.com>'s request
for review:
Bug 26328: Changing href attribute of svg images does not work when changing
display attribute as well
https://bugs.webkit.org/show_bug.cgi?id=26328

Attachment 31598: Different approach
https://bugs.webkit.org/attachment.cgi?id=31598&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Does this still work if you set href.baseVal.value= "newurl.png"?

You're removing the m_imageLoader.updateFromElementIgnoringPreviousError();
update from svgAttributeChanged, which makes me think that this will break
updates which are driven by JavaScript property changes.

Yes, it sucks that JS doesn't just call parseMappedAttribute.  Eventually we
need to fix that.

I think this broke href.baseVal, so r-