[webkit-reviews] review denied: [Bug 26474] WML Card Title does not get displayed on GtkLauncher : [Attachment 31633] updated patch to fix const_cast

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 22 00:03:04 PDT 2009


Eric Seidel <eric at webkit.org> has denied wajahat <wajahatmeister at gmail.com>'s
request for review:
Bug 26474: WML Card Title does not get displayed on GtkLauncher
https://bugs.webkit.org/show_bug.cgi?id=26474

Attachment 31633: updated patch to fix const_cast
https://bugs.webkit.org/attachment.cgi?id=31633&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
How do we test this?  Your ChangeLog mentions a layout test, but it seems to be
missing from your patch.

Otherwise this looks fine... but I don't understand how this method is ever
used or tested?


More information about the webkit-reviews mailing list