[webkit-reviews] review granted: [Bug 26580] Fix to enable XSSAuditor on child windows : [Attachment 31606] Patch with a test

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Daniel Bates <dbates at berkeley.edu>'s
request for review:
Bug 26580: Fix to enable XSSAuditor on child windows
https://bugs.webkit.org/show_bug.cgi?id=26580

Attachment 31606: Patch with a test
https://bugs.webkit.org/attachment.cgi?id=31606&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Thanks Dan!  Below are some minor style nits.  I'll fix them before landing the
patch.

> +XSSAuditor::XSSAuditor(Frame* frame) : m_frame(frame)

The ": m_frame" bit should be on the next line.

> +    layoutTestController.dumpChildFramesAsText();

The test doesn't create any child windows, so this call doesn't do anything.

> +    var event = document.createEvent('MouseEvent');
> +    event.initEvent('click', true, true);
> +    document.getElementById('anchorLink').dispatchEvent(event);

I think the anchor tag has a click() method that would be eaiser, but this does
the job.

> +if (window.layoutTestController) {
> +  layoutTestController.notifyDone();
> +}

No braces needed for if statements with single-line bodies.