[webkit-reviews] review granted: [Bug 25526] [Gtk] Additional support is needed for caret browsing : [Attachment 30015] homeendcaret.patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jun 21 01:49:16 PDT 2009


Eric Seidel <eric at webkit.org> has granted Xan Lopez <xan.lopez at gmail.com>'s
request for review:
Bug 25526: [Gtk] Additional support is needed for caret browsing
https://bugs.webkit.org/show_bug.cgi?id=25526

Attachment 30015: homeendcaret.patch
https://bugs.webkit.org/attachment.cgi?id=30015&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
This part looks fine.  We need tests for this though.  You should add a way to
turn on Caret browsing from DRT and then check that these edit commands are
enabled...

Sicne you already have other patches on this bug blocked by lack of tests, I'll
r+ this simple one and you can add more tests as part of those.


More information about the webkit-reviews mailing list