[webkit-reviews] review cancelled: [Bug 23124] RTL: Directionality always reset on hard line break : [Attachment 31050] Only reset directionality if caused by Unicode Control Char

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 17 19:22:34 PDT 2009


Jeremy Moskovich <playmobil at google.com> has cancelled Jeremy Moskovich
<playmobil at google.com>'s request for review:
Bug 23124: RTL:  Directionality always reset on hard line break
https://bugs.webkit.org/show_bug.cgi?id=23124

Attachment 31050: Only reset directionality if caused by Unicode Control Char
https://bugs.webkit.org/attachment.cgi?id=31050&action=review

------- Additional Comments from Jeremy Moskovich <playmobil at google.com>
* layout test added to cover the case of top level unicode control char.
* fixed style issues.
* Added comment.
* Included layout test results.

Mitz: Are there any other tests you'd like me to add here?  If so I'd be
grateful if you could mention them explicitly.

This patch changes the output of a couple of layout tests but they all still
appear to pass.
Rendering of the new "complex" layout test is identical to IE except for the
strange behavior I highlighted in my previous comment (i.e. it looks different
for reasons unrelated to this patch).


More information about the webkit-reviews mailing list