[webkit-reviews] review granted: [Bug 26345] build-webkit script has wrong default options for the Qt port, and the options are not passed on to qmake : [Attachment 31198] Fix bug when shadow-building

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 15 00:45:55 PDT 2009


Mark Rowe (bdash) <mrowe at apple.com> has granted Tor Arne Vestbø
<vestbo at webkit.org>'s request for review:
Bug 26345: build-webkit script has wrong default options for the Qt port, and
the options are not passed on to qmake
https://bugs.webkit.org/show_bug.cgi?id=26345

Attachment 31198: Fix bug when shadow-building
https://bugs.webkit.org/attachment.cgi?id=31198&action=review

------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
> +
> +	   WARNING: NO TEST CASES ADDED OR CHANGED
> +

You should remove this line. It's emitted only as a reminder to the patch
author.

r=me


More information about the webkit-reviews mailing list